Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ComposedSequenceExpressions #376

Merged
merged 3 commits into from
Feb 9, 2022
Merged

add ComposedSequenceExpressions #376

merged 3 commits into from
Feb 9, 2022

Conversation

ahwagner
Copy link
Member

@ahwagner ahwagner commented Jan 27, 2022

closes #363

@ahwagner
Copy link
Member Author

Confirmed that ComposedSequenceExpression JSON Schema correctly validates examples:

But does not correctly validate against this example:

@ahwagner
Copy link
Member Author

331dcfe now correctly validates this example:

@ahwagner ahwagner marked this pull request as ready for review January 28, 2022 22:33
Copy link
Contributor

@larrybabb larrybabb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahwagner great addition. I'm still not fully convinced about how the ordered array is guaranteed. It might be useful to clarify that unless I'm the only one that is missing the technical design behind that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants