Refine components in TraversalBlock
#554
Merged
+59
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Allele`, `CisPhasedBlock`, and `Terminus` can be specified directly on the `DerivativeMolecule`
Mrinal-Thomas-Epic
requested review from
ahwagner and
larrybabb
as code owners
Mrinal-Thomas-Epic
changed the title
TraversalBlockTraversalBlock
Mrinal-Thomas-Epic
force-pushed
the
traversal-block-components
branch
from
088f60d to
0f3ab58
Compare
ahwagner
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For message compactness,
Allele,CisPhasedBlock, andTerminusare no longer components ofTraversalBlock, since their traversal direction can always be inferred from surrounding adjacencies. Instead,Allele,CisPhasedBlock,Terminuscan now be specified directly as components ofDerivativeMolecule.See discussion #551 for reasoning.