Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance to_hex like the hexdump command #1472

Merged
merged 3 commits into from
Mar 15, 2020
Merged

Enhance to_hex like the hexdump command #1472

merged 3 commits into from
Mar 15, 2020

Conversation

ngugcx
Copy link
Contributor

@ngugcx ngugcx commented Mar 15, 2020

Support:

  1. Show ASCII.
    spdlog::debug("{:a}", spdlog::to_hex(data.begin(), data.end()));
    image
  2. Split output with different size per line.
    spdlog::debug("{:a}", spdlog::to_hex(data.begin(), data.end(), 16));
    image
    spdlog::debug("{:a}", spdlog::to_hex(data.begin(), data.end(), 8));
    image

@ngugcx
Copy link
Contributor Author

ngugcx commented Mar 15, 2020

The build failed with apt-get errors. Is there anything wrong with the build system? @gabime .

$ sudo -E apt-get -yq --no-install-suggests --no-install-recommends $(travis_apt_get_options) install clang-7
Reading package lists...
Building dependency tree...
Reading state information...
Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:
The following packages have unmet dependencies:
 clang-7 : Depends: libstdc++-4.9-dev but it is not installable
           Depends: libgcc-4.9-dev but it is not installable
           Depends: libobjc-4.9-dev but it is not installable
E: Unable to correct problems, you have held broken packages.
apt-get.diagnostics
apt-get install failed
The command "sudo -E apt-get -yq --no-install-suggests --no-install-recommends $(travis_apt_get_options) install clang-7" failed and exited with 100 during .

@gabime gabime self-requested a review March 15, 2020 14:36
@gabime gabime merged commit d14b8a9 into gabime:v1.x Mar 15, 2020
@gabime
Copy link
Owner

gabime commented Mar 15, 2020

Thanks. Cleaned a little and merged.

Very cool !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants