Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning about testing _WIN64 which might be undefined #1931

Merged
merged 1 commit into from
May 6, 2021

Conversation

vadz
Copy link
Contributor

@vadz vadz commented May 6, 2021

This warning is disabled by default, but is pretty useful and worth
enabling for MSVC, just as -Wundef for gcc, so fix it in Win32 build.


Sorry for another trivial PR, but while testing #1930 I've also stumbled on this one in Win32 build.

This warning is disabled by default, but is pretty useful and worth
enabling for MSVC, just as -Wundef for gcc, so fix it in Win32 build.
@gabime gabime merged commit 0a92d1d into gabime:v1.x May 6, 2021
@gabime
Copy link
Owner

gabime commented May 6, 2021

Thanks @vadz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants