Added common class for all qt objects #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed separate class for qt_sinks and also send logs to any custom qt (QObject) classes (QML, QFile, custom Widget etc.)
gabime
requested changes
Jul 28, 2021
include/spdlog/sinks/qt_sinks.h
Outdated
| if (textedit != nullptr) { | ||
| qtextedit_ = textedit; | ||
| qt_sink(QObject *qt_object = nullptr, const std::string &meta_method = "") { | ||
| if (qt_object != nullptr) { |
There was a problem hiding this comment.
i dont understand why to allow default nullptr in ctor if it get thrown afgerward if nullptr
There was a problem hiding this comment.
Actually it doesn't matter(nullptr or qobject*) in last solution 🤔
There was a problem hiding this comment.
I think pass nullptr into QMetaObject::invokemethod function is valid but does nothing with nullptr. But with a valid QObject* object it will invoke a function named in meta_method string.
gabime
requested changes
Jul 28, 2021
include/spdlog/sinks/qt_sinks.h
Outdated
| meta_method_ = "append"; | ||
| else if (std::is_same<T, QPlainTextEdit>::value) | ||
| meta_method_ = "appendPlainText"; | ||
| return Factory::template create<sinks::qt_sink_st>(logger_name, qt_object, meta_method_); |
There was a problem hiding this comment.
T is known at compile time, so template specialization should be used instead of the if statements.
There was a problem hiding this comment.
I will convert solution with template specialization
…bject Added factory funtion overloads for QTextEdit, QPlainTextEdit and QObject objects cleaned qt_sink ctor
mguludag
commented
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed separate class layout for qt_sinks and also send logs to any custom qt (QObject) classes (QML, QFile, custom Widget etc.)