Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce warnings with pedantic compiler -Wuseless-cast #2216

Merged
merged 4 commits into from
Dec 19, 2021
Merged

Reduce warnings with pedantic compiler -Wuseless-cast #2216

merged 4 commits into from
Dec 19, 2021

Conversation

vnepogodin
Copy link
Contributor

on unix systems getpid returns pid_t which refers to signed type same as int

@gabime
Copy link
Owner

gabime commented Dec 19, 2021

how can we be sure it is int in all non win32 platforms?

@vnepogodin
Copy link
Contributor Author

how can we be sure it is int in all non win32 platforms?

Implement adaptive cast

@gabime
Copy link
Owner

gabime commented Dec 19, 2021

what do you mean?

@vnepogodin
Copy link
Contributor Author

I'll implement that though

@vnepogodin
Copy link
Contributor Author

Well I did implement it

@vnepogodin
Copy link
Contributor Author

also would be nice to add -Wuseless-cast for CI/CD with gcc compiler

@gabime gabime merged commit cc30229 into gabime:v1.x Dec 19, 2021
@gabime
Copy link
Owner

gabime commented Dec 19, 2021

Thanks @vnepogodin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vnepogodin @gabime