When built with SPDLOG_FMT_EXTERNAL_HO consumers of the spdlog target… #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s depend on fmt The cmake/spdlogConfig.cmake.in file properly takes into account the fmt package dependency when building with SPDLOG_FMT_EXTERNAL:BOOL=ON but not when built with SPDLOG_FMT_EXTERNAL_HO:BOOL=ON. Prior to these changes SPDLOG_FMT_EXTERNAL_HO:BOOL=ON results in exported targets with INTERFACE_LINK_LIBRARIES that contain fmt::fmt-header-only. As such, the installed spdlogConfig.cmake file should attempt to find that dependency for the consumer.
|
Thanks @adamcalhoon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s depend on fmt
The cmake/spdlogConfig.cmake.in file properly takes into account the fmt
package dependency when building with SPDLOG_FMT_EXTERNAL:BOOL=ON but
not when built with SPDLOG_FMT_EXTERNAL_HO:BOOL=ON.
Prior to these changes SPDLOG_FMT_EXTERNAL_HO:BOOL=ON results in
exported targets with INTERFACE_LINK_LIBRARIES that contain
fmt::fmt-header-only.
As such, the installed spdlogConfig.cmake file should attempt to find
that dependency for the consumer.