Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace iterator difference with std::distance(revert #2030) #2509

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Replace iterator difference with std::distance(revert #2030) #2509

merged 1 commit into from
Oct 14, 2022

Conversation

kin4stat
Copy link
Contributor

motivation can be found here

#2030 (comment)

@gabime
Copy link
Owner

gabime commented Oct 13, 2022

I don’t want to switch go back and forth between PRs without good reason.
@neheb what do you think about reverting your PR due to this reasoning?

@neheb
Copy link
Contributor

neheb commented Oct 13, 2022

No real opinion on it.

@gabime
Copy link
Owner

gabime commented Oct 13, 2022

@kin4stat You forgot the r in the return. I would appreciate if you check your pr before posting.

@gabime gabime merged commit d011332 into gabime:v1.x Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kin4stat @gabime @neheb