Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -Wshadow warnings in spdlog::sinks::dist_sink #2599

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

robinlinden
Copy link
Contributor

@robinlinden robinlinden commented Jan 9, 2023

This is similar to fbba6df but fixes a few member functions missed in that commit.

spdlog/sinks/dist_sink.h:34:41: error: declaration of 'sink' shadows a member of 'spdlog::sinks::dist_sink<std::mutex>' [-Werror=shadow]
   34 |     void add_sink(std::shared_ptr<sink> sink)
      |                   ~~~~~~~~~~~~~~~~~~~~~~^~~~
In file included from spdlog/sinks/base_sink.h:14,
                 from spdlog/sinks/dist_sink.h:6:
spdlog/sinks/sink.h:13:1: note: shadowed declaration is here
   13 | {
      | ^

This is similar to fbba6df but fixes a
few member functions missed in that commit.
@gabime gabime merged commit 6df64c6 into gabime:v1.x Jan 9, 2023
@gabime
Copy link
Owner

gabime commented Jan 9, 2023

Thanks @robinlinden

@robinlinden robinlinden deleted the fix-wshadow branch January 10, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants