Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utf8_to_wstrbuf now handles invalid utf8 sequences #3244

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

captainurist
Copy link
Contributor

Fixes #3241

@gabime gabime merged commit 5673e9e into gabime:v1.x Nov 5, 2024
14 of 15 checks passed
@gabime
Copy link
Owner

gabime commented Nov 5, 2024

Thanks @captainurist

@gabime
Copy link
Owner

gabime commented Nov 5, 2024

@captainurist Seems that some of the new tests fail. Can you take a look?

@captainurist
Copy link
Contributor Author

Yes, looking at it now.

@captainurist
Copy link
Contributor Author

@gabime OK test failures are easy to fix, preparing a PR.

For the compilation errors, these make no sense to me:

C:\projects\spdlog\tests\test_misc.cpp(176): error C2678: binary '==': no operator found which takes a left-hand operand of type 'Catch::ExprLhs<spdlog::wmemory_buf_t &>' (or there is no acceptable conversion) [C:\projects\spdlog\build\tests\spdlog-utests.vcxproj]

...

C:\projects\spdlog\tests\test_misc.cpp(176): note: while trying to match the argument list '(Catch::ExprLhs<spdlog::wmemory_buf_t &>, const wchar_t [1])'

This comparison is not in the code. Let's rerun tests with the new PR and see if it helps resolve this too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

msvc_sink throws on invalid utf-8
2 participants