ugly poc #1
Open
ugly poc #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vcraescu - we have this in https://github.com/Sylius/Sylius/blob/v0.18.0/src/Sylius/Component/Core/Promotion/Filter/TaxonFilter.php so we should be able to use it in our fork. hopefully. me happy ^^ |
gabiudrescu
pushed a commit
that referenced
this pull request
Jun 6, 2017
[Behat] Add scenarios for adding select attribute type
gabiudrescu
pushed a commit
that referenced
this pull request
Jun 6, 2017
Make channel pricing translatable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The promotion has been configured like this:
The cart behavior is this:
The downside is I couldn't make this accept multiple taxons, therefor, to have a functional POC, I reduced it to only one taxon as a filter.
This means we can implement campaigns such as "if you have products from books taxon in cart, apply 10% item discount on products from books taxon", but we lack "if you have products from books taxon in cart, apply 10% item discount on products from books and mobile phone taxons".
Let's hope @vcraescu brings light to this 👯