Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict param to enforce RECAP_URLS for gateway #408

Merged
merged 1 commit into from
Oct 20, 2023

Commits on Oct 20, 2023

  1. Add strict param to enforce RECAP_URLS for gateway

    The gateway has a gaping security hole. It allows users to ls/schema on
    arbitrary URLs using whatever credentials the gateway host might have. This is
    dangerous in a cloud environment where the host might be given a service account
    with access to systems that end users should not have access to. It also is
    dangerous now that we have a FilesystemClient that allows users to read the
    local disk.
    
    I've fixed this by forcing the gateway to run `ls` and `schema` commands with
    `struct=True`. This parmater forces any URLs to be defined in the RECAP_URLS
    environment variable. Unknown URLs will now fail with a ValueError.
    
    I have left the CLI with `strict=False` because the users running locally should
    be able to query whatever they want using the credentials they have on their
    machine.
    criccomini committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    8704e1d View commit details
    Browse the repository at this point in the history