Support postgresql enums #414
Conversation
mjperrone
changed the title
mjperrone
force-pushed
the
mp/pg-enums
branch
from
776c5b9
to
22fe4e5
Compare
recap/clients/postgresql.py
Outdated
| array_agg(enumlabel) AS enum_values | ||
| FROM pg_catalog.pg_enum | ||
| GROUP BY enumtypid | ||
| ) enums ON enums.enumtypid = pg_type.oid |
There was a problem hiding this comment.
Nit: pg_catalog.pg_type.oid for consistency?
| @@ -55,7 +67,8 @@ def setup_class(cls): | |||
| test_bit_array BIT(8)[], | |||
| test_not_null_array INTEGER[] NOT NULL, | |||
| test_int_array_2d INTEGER[][], | |||
| test_text_array_3d TEXT[][][] | |||
| test_text_array_3d TEXT[][][], | |||
| test_enum_mood test_enum_type_mood | |||
There was a problem hiding this comment.
WDYT about adding a secnod col that's test_enum_type_mood[] to validate enum arrays?
There was a problem hiding this comment.
I tried and it fails as-is. With that column type data_type is ARRAY and udt_name is _test_enum_type_mood interestingly.
I'd like to keep addressing arrays out of scope of this PR if that's okay with you.
There was a problem hiding this comment.
Ticket to track supporting that: #416
|
Thanks for submitting this PR! I left some comments and thoughts, but this looks good overall. |
|
Regarding the failing integration test, expected: EnumType(type_=enum, logical=None, alias=None, doc=None, extra_attrs={'default': None}, symbols=['sad', 'ok', 'happy'])received: EnumType(type_=enum, logical=None, alias=None, doc=None, extra_attrs={}, symbols=['sad', 'ok', 'happy'])Need to look into this more, but I don't think the converter is including the default value for any of the types. |
|
Looks like it may be possible by looking at |
|
Awesome! Merged in. Thanks for opening the enum+array ticket. :) |
|
Released in 0.10.1! https://pypi.org/project/recap-core/0.10.1/ |
@alexdemeo gave this to me to help me run the integration tests locally when implementing #414. I assume he grabbed the docker config from [here(https://github.com/mjperrone/recap/blob/a0cbb2a47d2e3a789d76b5ba0f222b9ea8c25f8a/.github/workflows/ci.yaml#L61-L88). I grabbed the `RECAP_URLS` value from [here(https://github.com/mjperrone/recap/blob/a0cbb2a47d2e3a789d76b5ba0f222b9ea8c25f8a/.github/workflows/ci.yaml#L165). Admittedly I did not run all the integration tests as that was too long (just `RECAP_URLS='["postgresql://postgres:password@localhost:5432/testdb"]' pdm run pytest tests/integration/clients/test_postgresql.py` but this should be closer to describing how to all the int tests.
@alexdemeo gave this to me to help me run the integration tests locally when implementing #414. I assume he grabbed the docker config from here: https://github.com/mjperrone/recap/blob/a0cbb2a47d2e3a789d76b5ba0f222b9ea8c25f8a/.github/workflows/ci.yaml#L61-L88 I grabbed the `RECAP_URLS` value from here: https://github.com/mjperrone/recap/blob/a0cbb2a47d2e3a789d76b5ba0f222b9ea8c25f8a/.github/workflows/ci.yaml#L165 Admittedly I did not run all the integration tests as that was too long (just `RECAP_URLS='["postgresql://postgres:password@localhost:5432/testdb"]' pdm run pytest tests/integration/clients/test_postgresql.py` but this should be closer to describing how to all the int tests.
Support postgresql enums
Adds support for postgresql enums, addressing #415.
This uses the pg_type and pg_enum tables to discover the valid enum values for any columns using
Limitations
There are other postgresql custom types that I am not attempting to support in this PR:
Validation
Using the enum example in the postgres docs, the integration test creates a new custom enum type, uses it in the test table, and expects the recap
EnumTypeto be found.I also added a unit test for basically the same thing.