Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ Allow using file paths in --token and GHORG_*_TOKEN… #358

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

dvonessen
Copy link
Contributor

… environment variable.

Status

READY

Description

This feature enables usage of file path's for --token and corresponding env vars GHORG_*_TOKEN.

I am by far not a go programming expert, but I testet this feature with the --token and the GHORG_*_TOKEN environment variable. Either with the token itself and with a path given.

If this feature is ok enough, I will also add documentation.
I am not sure how to write a test for this feature, if someone can guide me, I would also add some tests.

closes #356

@gabrie30
Copy link
Owner

Thanks for the PR! At a glance it looks good but will take a closer look once I have some time.

@dvonessen
Copy link
Contributor Author

That'll be great! I added documentation.

@dvonessen
Copy link
Contributor Author

If this will work I would also add this feature to --base-url, I want to use ghorg to sync also my works repos, but it is not allowed make the URL public, therefore encrypting it and use the file as the source.
The positive side, everything is implemented to do that. ;-)

Hope to here from you soon. Thank's!

@gabrie30 gabrie30 merged commit a50b6b3 into gabrie30:master Oct 26, 2023
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow token configuration be a path to a file which gets loaded.
2 participants