Fix json detected as dbf when it starts with low ascii values #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byte 0x09 represents ninth month in dbf header, but it is also the ascii value of <TAB>. This made dbf detection pass for json and txt files happening to contain these low ascii values at the start. This commit improves dbf detection to check for several null bytes in the input. json and txt files never contain null bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Byte 0x09 represents ninth month in dbf header, but it is also the ascii
value of < TAB >. This made dbf detection pass for json and txt files
happening to contain low ascii values at the start.
This commit improves dbf detection to check for several null bytes in
the input. json and txt files never contain null bytes.