add jxr support #155 #312
Merged
add jxr support #155 #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriel-vasile
requested changes
Sep 1, 2022
There was a problem hiding this comment.
Hi, looks good. I left some improvements to do before I can merge this.
Can you please use the attached jxr file for testdata? jxr.jxr.zip. It is smaller in size and it is generated by me so I won't have licensing issues with it.
|
All issues addressed. |
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
=======================================
Coverage 94.96% 94.96%
=======================================
Files 3 3
Lines 159 159
=======================================
Hits 151 151
Misses 6 6
Partials 2 2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
gabriel-vasile
approved these changes
Sep 3, 2022
kodiakhq bot
referenced
this pull request
in cloudquery/cloudquery
Apr 1, 2023
…#9604) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/gabriel-vasile/mimetype](https://togithub.com/gabriel-vasile/mimetype) | indirect | patch | `v1.4.1` -> `v1.4.2` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>gabriel-vasile/mimetype</summary> ### [`v1.4.2`](https://togithub.com/gabriel-vasile/mimetype/releases/tag/v1.4.2) [Compare Source](https://togithub.com/gabriel-vasile/mimetype/compare/v1.4.1...v1.4.2) #### What's Changed - Improve mov detection; closes [#​302](https://togithub.com/gabriel-vasile/mimetype/issues/302) by [@​gabriel-vasile](https://togithub.com/gabriel-vasile) in [https://github.com/gabriel-vasile/mimetype/pull/304](https://togithub.com/gabriel-vasile/mimetype/pull/304) - \[codespell] Fix typos. by [@​mdosch](https://togithub.com/mdosch) in [https://github.com/gabriel-vasile/mimetype/pull/303](https://togithub.com/gabriel-vasile/mimetype/pull/303) - Detect UStar tar archives by [@​chrisnovakovic](https://togithub.com/chrisnovakovic) in [https://github.com/gabriel-vasile/mimetype/pull/308](https://togithub.com/gabriel-vasile/mimetype/pull/308) - add jxr support [#​155](https://togithub.com/gabriel-vasile/mimetype/issues/155) by [@​dijotmathews](https://togithub.com/dijotmathews) in [https://github.com/gabriel-vasile/mimetype/pull/312](https://togithub.com/gabriel-vasile/mimetype/pull/312) - Added support for JXS file format by [@​V-R-Dighe](https://togithub.com/V-R-Dighe) in [https://github.com/gabriel-vasile/mimetype/pull/319](https://togithub.com/gabriel-vasile/mimetype/pull/319) - Bump golang.org/x/net from 0.7.0 to 0.8.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/gabriel-vasile/mimetype/pull/367](https://togithub.com/gabriel-vasile/mimetype/pull/367) #### New Contributors - [@​mdosch](https://togithub.com/mdosch) made their first contribution in [https://github.com/gabriel-vasile/mimetype/pull/303](https://togithub.com/gabriel-vasile/mimetype/pull/303) - [@​chrisnovakovic](https://togithub.com/chrisnovakovic) made their first contribution in [https://github.com/gabriel-vasile/mimetype/pull/308](https://togithub.com/gabriel-vasile/mimetype/pull/308) - [@​dijotmathews](https://togithub.com/dijotmathews) made their first contribution in [https://github.com/gabriel-vasile/mimetype/pull/312](https://togithub.com/gabriel-vasile/mimetype/pull/312) - [@​V-R-Dighe](https://togithub.com/V-R-Dighe) made their first contribution in [https://github.com/gabriel-vasile/mimetype/pull/319](https://togithub.com/gabriel-vasile/mimetype/pull/319) **Full Changelog**: gabriel-vasile/mimetype@v1.4.1...v1.4.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 3am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTQuMCIsInVwZGF0ZWRJblZlciI6IjM0LjE1NC4wIn0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added support for jxr.