improve performance for text detection #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
they are usually the slowest
This commit improves memory allocations inside nd-json by using a scanLines function that works with already allocated buffer. Previous version of code was using bufio.Scanner which allocates his own copy of the buffer. before: BenchmarkText/application/x-ndjson-8 663314 2027 ns/op 4306 B/op 6 allocs/op after: BenchmarkText/application/x-ndjson-8 1930292 678.6 ns/op 160 B/op 4 allocs/op
pellared
referenced
this pull request
in open-telemetry/opentelemetry-go-contrib
May 24, 2024
….4 (#5660) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/gabriel-vasile/mimetype](https://togithub.com/gabriel-vasile/mimetype) | `v1.4.3` -> `v1.4.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>gabriel-vasile/mimetype (github.com/gabriel-vasile/mimetype)</summary> ### [`v1.4.4`](https://togithub.com/gabriel-vasile/mimetype/releases/tag/v1.4.4) [Compare Source](https://togithub.com/gabriel-vasile/mimetype/compare/v1.4.3...v1.4.4) #### What's Changed ##### Security fixes: Update `golang.org/x/net` to latest. Fixes: [CVE-2023-45288](https://deps.dev/advisory/osv/GO-2024-2687) ##### Performance improvements: - Change tar detection to use checksum instead of legal ranges of values in [https://github.com/gabriel-vasile/mimetype/pull/466](https://togithub.com/gabriel-vasile/mimetype/pull/466) - ftyp: exit asap to prevent mem allocs in [https://github.com/gabriel-vasile/mimetype/pull/517](https://togithub.com/gabriel-vasile/mimetype/pull/517) - Improve x-subrip detection performance in [https://github.com/gabriel-vasile/mimetype/pull/524](https://togithub.com/gabriel-vasile/mimetype/pull/524) - improve performance for text detection in [https://github.com/gabriel-vasile/mimetype/pull/532](https://togithub.com/gabriel-vasile/mimetype/pull/532) - Using io.ReadAll instead of ioutil.ReadAll by [@​phihungtf](https://togithub.com/phihungtf) in [https://github.com/gabriel-vasile/mimetype/pull/525](https://togithub.com/gabriel-vasile/mimetype/pull/525) Benchmarks: ```bash before: BenchmarkText/application/x-ndjson-8 663314 2027 ns/op 4306 B/op 6 allocs/op BenchmarkSliceRand-8 688160 1690 ns/op 728 B/op 75 allocs/op BenchmarkSrt-8 946042 1089 ns/op 4240 B/op 5 allocs/op after: BenchmarkText/application/x-ndjson-8 1930292 678.6 ns/op 160 B/op 4 allocs/op BenchmarkSliceRand-8 1232066 1173 ns/op 160 B/op 4 allocs/op BenchmarkSrt-8 3235448 368.8 ns/op 64 B/op 2 allocs/op ``` #### New Contributors - [@​phihungtf](https://togithub.com/phihungtf) made their first contribution in [https://github.com/gabriel-vasile/mimetype/pull/525](https://togithub.com/gabriel-vasile/mimetype/pull/525) **Full Changelog**: gabriel-vasile/mimetype@v1.4.3...v1.4.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-telemetry/opentelemetry-go-contrib). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbIlNraXAgQ2hhbmdlbG9nIiwiZGVwZW5kZW5jaWVzIl19--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code was relying on
bufio.Scannerto split the input into lines.This is inefficient because
bufio.Scannerallocates his own copy of the buffer. In our use case, where the whole buffer is a few KB, there is no point of usingbufio(other that it was easy to use.)Scanning the buffer for
\ncharacters withbytes.Cutis much faster because it does no allocs.