json: improve performance by using a pool of scanners #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
gabriel-vasile
commented
May 26, 2024
gabriel-vasile
commented
it helps by reducing memory allocations to amortized 0
➜ mimetype git:(bench) ✗ benchstat master sync_pool
goos: linux
goarch: amd64
pkg: github.com/gabriel-vasile/mimetype
cpu: Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz
│ master │ sync_pool │
│ sec/op │ sec/op vs base │
Files/json.json/application/json-8 1.403µ ± 0% 1.355µ ± 1% -3.39% (p=0.000 n=20)
Files/ndjson.xl.ndjson/application/x-ndjson-8 8.655µ ± 1% 8.504µ ± 1% -1.76% (p=0.001 n=20)
Files/ndjson.ndjson/application/x-ndjson-8 3.069µ ± 1% 2.958µ ± 5% ~ (p=0.129 n=20)
geomean 3.340µ 3.242µ -2.92%
│ master │ sync_pool │
│ B/op │ B/op vs base │
Files/json.json/application/json-8 120.0 ± 0% 0.0 ± 0% -100.00% (p=0.000 n=20)
Files/ndjson.xl.ndjson/application/x-ndjson-8 720.0 ± 0% 0.0 ± 0% -100.00% (p=0.000 n=20)
Files/ndjson.ndjson/application/x-ndjson-8 240.0 ± 0% 0.0 ± 0% -100.00% (p=0.000 n=20)
geomean 274.7 ? ¹ ²
¹ summaries must be >0 to compute geomean
² ratios must be >0 to compute geomean
│ master │ sync_pool │
│ allocs/op │ allocs/op vs base │
Files/json.json/application/json-8 4.000 ± 0% 0.000 ± 0% -100.00% (p=0.000 n=20)
Files/ndjson.xl.ndjson/application/x-ndjson-8 24.00 ± 0% 0.00 ± 0% -100.00% (p=0.000 n=20)
Files/ndjson.ndjson/application/x-ndjson-8 8.000 ± 0% 0.000 ± 0% -100.00% (p=0.000 n=20)
geomean 9.158 ? ¹ ²
¹ summaries must be >0 to compute geomean
² ratios must be >0 to compute geomean
there is no reason to make it concurrent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.