Expose dockerfile and args arguments under build #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jashparekh
changed the title
gabrieldemarmiesse
requested changes
Sep 25, 2023
added 4 commits
September 26, 2023 07:41
added 3 commits
September 26, 2023 09:25
Made the requested changes, @gabrieldemarmiesse can you take another look? |
|
Hey @gabrieldemarmiesse - Following up for your review on this PR |
|
Sure, I'll take a look! |
gabrieldemarmiesse
merged commit 1dbaae8
into
gabrieldemarmiesse:master
36 checks passed
|
Thank you @gabrieldemarmiesse, can you also cut a new release with this change? I have created this PR to bump the version |
|
We'll first merge your other PR about pyproject.toml :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.