Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace setup.py by a pyproject.toml #478

Merged
merged 9 commits into from
Sep 29, 2023
Merged

Replace setup.py by a pyproject.toml #478

merged 9 commits into from
Sep 29, 2023

Conversation

jashparekh
Copy link
Contributor

Closes #474

@jashparekh jashparekh marked this pull request as draft September 26, 2023 11:06
gabrieldemarmiesse
gabrieldemarmiesse approved these changes Sep 26, 2023
View reviewed changes
Copy link
Owner

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great! Thanks a lot!

@jashparekh jashparekh marked this pull request as ready for review September 27, 2023 04:47
@gabrieldemarmiesse gabrieldemarmiesse merged commit a1f82e0 into gabrieldemarmiesse:master Sep 29, 2023
36 checks passed
@jashparekh jashparekh deleted the replace_setup_py branch September 29, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldemarmiesse gabrieldemarmiesse gabrieldemarmiesse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace setup.py by a pyproject.toml
2 participants
@jashparekh @gabrieldemarmiesse