Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing tty and interactive flags to container create and start #545

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Add missing tty and interactive flags to container create and start #545

merged 1 commit into from
Feb 1, 2024

Conversation

LewisGaul
Copy link
Collaborator

No description provided.

gabrieldemarmiesse
gabrieldemarmiesse approved these changes Feb 1, 2024
View reviewed changes
Copy link
Owner

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I don't think we can add unit tests for this.

@gabrieldemarmiesse gabrieldemarmiesse enabled auto-merge (squash) February 1, 2024 18:13
@gabrieldemarmiesse gabrieldemarmiesse merged commit d8420f9 into gabrieldemarmiesse:master Feb 1, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldemarmiesse gabrieldemarmiesse gabrieldemarmiesse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LewisGaul @gabrieldemarmiesse