Add stream output for pruning #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldemarmiesse
requested changes
Mar 17, 2024
There was a problem hiding this comment.
The feature looks good and the tests too. In terms of readability, we'll prefer to put the if statement outside the assert to lower the complexity of the logic and make it more readable. The else True becomes then unnecessary.
After those small fixes, we can merge :) thanks for the PR!
Indeed this seems like a good idea, we'll have a consistent api :) |
Co-authored-by: Gabriel de Marmiesse <gabrieldemarmiesse@gmail.com>
Co-authored-by: Gabriel de Marmiesse <gabrieldemarmiesse@gmail.com>
Co-authored-by: Gabriel de Marmiesse <gabrieldemarmiesse@gmail.com>
Co-authored-by: Gabriel de Marmiesse <gabrieldemarmiesse@gmail.com>
Co-authored-by: Gabriel de Marmiesse <gabrieldemarmiesse@gmail.com>
gabrieldemarmiesse
approved these changes
Mar 22, 2024
gabrieldemarmiesse
merged commit 070bf6e
into
gabrieldemarmiesse:master
35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #396
Not sure if we need to update this? #499
Will complete the overloading for other pruning, such as for Docker Image, Network, Buildx, etc. when this one gets approved.