feat: Add --wait-timeout option for docker.compose.up
#573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I seems that the version of docker compose we use in the CI is not recent enough. Maybe we should update it? |
|
Yeah it added in |
|
I've check it locally with 2.17.0 and 2.17.2 and two tests was failed ================================================================== short test summary info ===================================================================
FAILED tests/python_on_whales/components/test_compose.py::test_project_directory_env_files - python_on_whales.exceptions.DockerException: The docker command executed was `/usr/bin/docker compose --file /home/taragolis/Projects/common/python-on-wh...
FAILED tests/python_on_whales/components/test_compose.py::test_compose_logs_follow - assert 1 >= 5
========================================================== 2 failed, 71 passed in 312.91s (0:05:12) ========================================================== |
|
I could have a look on this tests and try to adopt tests to the newer version of docker-compose. Any preference to the target version of docker-compose? |
|
The latest one is fine by me |
|
@MisterOwlPT updated the compose version in the CI, let's see if that fixes the tests here Edit: Noice |
gabrieldemarmiesse
requested changes
Mar 29, 2024
gabrieldemarmiesse
approved these changes
Mar 29, 2024
|
dang this PR is cursed |
gabrieldemarmiesse
merged commit a10959c
into
gabrieldemarmiesse:master
35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for wait timeout, https://docs.docker.com/reference/cli/docker/compose/up/#options
--wait-timeout Maximum duration to wait for the project to be running|healthy