-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for 'docker version' and 'podman version' #593
Add support for 'docker version' and 'podman version' #593
Conversation
I would be happy to drop support for pydantic V1 when it's end of life, so in one month. If this PR is not a pressing matter, we can merge it just after :) |
@@ -37,3 +37,4 @@ markers = [ | |||
"podman: marks tests as needing a podman engine to run" | |||
] | |||
xfail_strict = true | |||
pythonpath = ["./"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes just pytest
work from the project root, rather than needing python3 -m pytest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as usual! We can merge when pydantic v1 is EOL
To be clear, I updated it to be compatible with pydantic v1 so that we don't need to wait. |
Ho my bad, I went over it a bit too quickly since I already read the diff once. Let's merge it now :) |
fd18ff4
into
gabrieldemarmiesse:master
Fixes #591
APIVersion
andBuiltTime
fields won't be recognised with pydantic v1)