Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 'docker version' and 'podman version' #593

Merged

Conversation

LewisGaul
Copy link
Collaborator

@LewisGaul LewisGaul commented May 22, 2024

Fixes #591

  • Resolve what to do about the added requirement for pydantic v2
    • Making it work with pydantic v1 for now (although podman's APIVersion and BuiltTime fields won't be recognised with pydantic v1)
    • Raised separate issue for removing pydantic v1 support: Drop support for pydantic v1 #594
  • Add tests

@gabrieldemarmiesse
Copy link
Owner

gabrieldemarmiesse commented May 23, 2024

I would be happy to drop support for pydantic V1 when it's end of life, so in one month. If this PR is not a pressing matter, we can merge it just after :)

@LewisGaul LewisGaul marked this pull request as ready for review May 25, 2024 12:12
@@ -37,3 +37,4 @@ markers = [
"podman: marks tests as needing a podman engine to run"
]
xfail_strict = true
pythonpath = ["./"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes just pytest work from the project root, rather than needing python3 -m pytest

Copy link
Owner

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as usual! We can merge when pydantic v1 is EOL

@LewisGaul
Copy link
Collaborator Author

Looks good as usual! We can merge when pydantic v1 is EOL

To be clear, I updated it to be compatible with pydantic v1 so that we don't need to wait.

@gabrieldemarmiesse
Copy link
Owner

Ho my bad, I went over it a bit too quickly since I already read the diff once. Let's merge it now :)

@gabrieldemarmiesse gabrieldemarmiesse merged commit fd18ff4 into gabrieldemarmiesse:master May 29, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement DockerClient.version()
2 participants