Fix #6 - do not mutate vuex store outside mutation handlers #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a simple deep clone of the old state prevents setting off 'Error: do not mutate vuex store state outside mutation handlers' when merging the preset statesPaths
de-activating the previous fixes in commit f028348 will let this new test fail
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 98.24% 98.43% +0.19%
==========================================
Files 2 2
Lines 57 64 +7
Branches 10 12 +2
==========================================
+ Hits 56 63 +7
Partials 1 1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a simple deep clone of the old state prevents setting off 'Error: do not mutate vuex store state outside mutation handlers' when merging the preset statesPaths.
A test was added as well, which, if the new deep clone is removed, fails nicely with the mentioned error message.
Related #6