Issue 13 possibility to add more options #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For compability with ES5 according to gabzim#2
johachi
force-pushed
the
issue-13-possibility-to-add-more-options
branch
2 times, most recently
from
a232293
to
66278c8
Compare
johachi
force-pushed
the
issue-13-possibility-to-add-more-options
branch
from
66278c8
to
5e522d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to pass either an
objector anumbertonumberOfSegements. When passed as an object, the value of the keynumberOfSegmentswill be used. Identical polygons will be returned when passing a number or passing an object.This will close #13 and opens up for the possibility to add more options for the creation of the polygon.
TODO: Check if error should be thrown whennumberOfSegemntsis an array, or if it should keep current behavior ( see this post #9 (comment) )If error should be thrown, then add that functionallity. If error should not be thrown, add&& !Array.isArraytoelse if (typeof options === "object")condition forgetNumberOfSegments().