Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add named constructor for UnsupportedHttpMethodException #17

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Add named constructor for UnsupportedHttpMethodException #17

merged 2 commits into from
Apr 21, 2023

Conversation

Chemaclass
Copy link
Member

🔖 Changes

  • Add named constructor: UnsupportedHttpMethodException::withName()

@Chemaclass Chemaclass added the refactoring Refactoring or cleaning related label Apr 20, 2023
@Chemaclass Chemaclass self-assigned this Apr 20, 2023
antonio-gg-dev
antonio-gg-dev approved these changes Apr 20, 2023
View reviewed changes
src/Router/Router.php
use ReflectionFunction;

use function get_class;

final class Router
{
/**
* @throws ReflectionException
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops my bad 😣😁

@Chemaclass Chemaclass merged commit 2c118f2 into main Apr 21, 2023
@Chemaclass Chemaclass deleted the named-const-http-method-exception branch April 21, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusValeraDev JesusValeraDev JesusValeraDev approved these changes

@antonio-gg-dev antonio-gg-dev antonio-gg-dev approved these changes

Assignees

@Chemaclass Chemaclass

Labels
refactoring Refactoring or cleaning related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Chemaclass @JesusValeraDev @antonio-gg-dev