Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve readme example #18

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Improve readme example #18

merged 1 commit into from
Apr 21, 2023

Conversation

Chemaclass
Copy link
Member

🔖 Changes

  • Update README file, improving the example and working demo sections.

@Chemaclass Chemaclass added the documentation Improvements or additions to documentation label Apr 21, 2023
@Chemaclass Chemaclass self-assigned this Apr 21, 2023
antonio-gg-dev
antonio-gg-dev approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@antonio-gg-dev antonio-gg-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, the example in the README.md is very cool! I think we could improve the example.php too by adding similar situations to it.

@Chemaclass
Copy link
Member Author

Thanks for the hint! @Tito-Kati, feel free to do it in a follow up PR ;)

@Chemaclass Chemaclass merged commit 0531252 into main Apr 21, 2023
@Chemaclass Chemaclass deleted the improve-readme-example branch April 21, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonio-gg-dev antonio-gg-dev antonio-gg-dev approved these changes

@JesusValeraDev JesusValeraDev Awaiting requested review from JesusValeraDev

Assignees

@Chemaclass Chemaclass

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Chemaclass @antonio-gg-dev