Create JsonResponse #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chemaclass
force-pushed
the
create-json-response
branch
from
30297c9 to
beb787c
Compare
Chemaclass
force-pushed
the
create-json-response
branch
from
7ca3183 to
aeea2ef
Compare
antonio-gg-dev
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
The main motivation is to get rid of this json header from the client side:
https://github.com/gacela-project/api-skeleton/blob/main/public/index.php#L18
🔖 Changes
The aim is to be able to use
JsonResponsewhich receives an array,and it converts it to a json and adds the proper json header. Eg:
🤔 Follow up
How can we get rid of the other custom headers?
Eg: in the first screenshot, line 17:
header('Access-Control-Allow-Origin: *');