Require response to be a string or implements Stringable #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesusValeraDev
approved these changes
Apr 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
To improve DX, we should ensure that the responses are strings or implement the Stringable interface (which was added in version 8.0 of PHP).
This was already being done accidentally, but now the code makes sure of it and throws a very clear exception to the developer if this is not the case.
This allows for more flexibility, for example, if someone is doing a simple CRUD, they could directly respond with their models in their controllers as long as they implement the Stringable interface (leaving aside opinions on whether this is more or less correct).
🔖 Changes