Match route #9
Merged
Match route #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $_SERVER['REQUEST_URI'] = 'https://example.org/expected/uri'; | ||
| $_SERVER['REQUEST_METHOD'] = $testMethod; | ||
|
|
||
| $this->expectOutputString(''); |
There was a problem hiding this comment.
Should we throw an exception with a 404 error code? @Tito-Kati @Chemaclass
There was a problem hiding this comment.
Yeah! We currently don't have support for 404, so this is a nice follow up feature to implement ;)
| $_SERVER['REQUEST_URI'] = 'https://example.org/expected/uri'; | ||
| $_SERVER['REQUEST_METHOD'] = 'GET'; | ||
|
|
||
| $this->expectOutputString(''); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Add the match() method to the Router that allows subscribing a route to multiple HTTP methods simultaneously.
🔖 Changes