Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for automatic sunset and sunrise detection via {suncalc} #33

Merged
merged 7 commits into from
Sep 29, 2020

Conversation

pat-s
Copy link
Contributor

@pat-s pat-s commented Aug 11, 2020

fixes #32

I also made some opinionated changes to the defaults of dark_start and dark_end to be able to add args lat and lon. This might break backward comp for some users even though I do not think that many will use the current defaults in production.

There might be more robust ways to implement this and as you can see I did not add any checks or assertions but it does the job ;)

I also did a run of styler::tidyverse_style() - just cherry pick the other changes if you dislike the styling.

@gadenbuie
Copy link
Owner

This is a really cool idea, thanks Pat! I've been picking away at a biggish internal refactor and I'll merge this when I get that worked out.

@gadenbuie gadenbuie merged commit 296c7b6 into gadenbuie:master Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use_theme_auto(): Support for automatic calculation of sunset and sunrise times
2 participants