Add support for automatic sunset and sunrise detection via {suncalc} #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #32
I also made some opinionated changes to the defaults of
dark_start
anddark_end
to be able to add argslat
andlon
. This might break backward comp for some users even though I do not think that many will use the current defaults in production.There might be more robust ways to implement this and as you can see I did not add any checks or assertions but it does the job ;)
I also did a run of
styler::tidyverse_style()
- just cherry pick the other changes if you dislike the styling.