-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rstheme_terminal_colors #63
Conversation
Here's the code where I use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you @nsgrantham! I also really like your poolside theme and I'd be happy for it to be part of rsthemes if that's something you're interested in.
I made one small suggestion to include your handle in the NEWS item.
I also need to check that the _terminal.scss
partial isn't included twice when using rstheme_terminal_colors()
. That might not be trivial to change; I think it's included in the base themes directly since it hasn't yet been customizable.
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
Thanks, added my username to the NEWS item. Glad you like Poolside! I'd love to add it to rsthemes, I'll open a PR when I'm done fiddling with it. I don't entirely understand the |
Thanks @nsgrantham and don't worry, I'll handle the |
Conflicts: NEWS.md
which required moving the _terminal.scss partial to the end of the theme sass_stack
Also automatically set bright colors to corresponding color by default
@nsgrantham sorry for the delay on this and thanks again for contributing the PR! I tweaked the function signature and default arguments a bit. I also went through and added terminal colors to most themes in rsthemes, which is exciting! |
Addresses #61. I implemented your recommended changes, the rainbow parens was a helpful example to follow, thank you. I tested this on my end and it's looking good. Let me know if there is something you'd like me to take a second pass at!