Upgrade to vite 5

.github/workflows/ci.yml

@@ -24,6 +24,8 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: ./.github/actions/setup-test-env
+      - name: Build JS
+        run: pnpm build
       - name: Run Lint
         run: pnpm run lint
 

package.json

@@ -10,8 +10,8 @@
     "lint:fix": "prettier --loglevel warn --write \"packages/**/*.{ts,tsx}\" && eslint \"packages/**/*.{ts,tsx}\" --quiet --fix",
     "release": "pnpm -F=fastify-renderer publish",
     "preinstall": "npx only-allow pnpm",
-    "prerelease": "pnpm -F=fastify-renderer run gitpkg publish",
-    "test": "vitest --no-threads"
+    "prerelease": "pnpm -F=fastify-renderer exec gitpkg publish",
+    "test": "vitest --pool=forks"
   },
   "repository": {
     "type": "git",
@@ -44,7 +44,7 @@
     "eslint-plugin-react": "^7.33.2",
     "eslint-plugin-react-hooks": "^4.6.0",
     "fs-extra": "^11.1.0",
-    "vitest": "^0.34.6",
+    "vitest": "^1.0.4",
     "playwright-chromium": "^1.39.0",
     "prettier": "^2.8.8",
     "prettier-plugin-organize-imports": "^3.2.3",

packages/fastify-renderer/package.json

@@ -1,13 +1,19 @@
 {
   "name": "fastify-renderer",
-  "version": "0.4.1",
+  "version": "0.5.0",
   "description": "Simple, high performance client side app renderer for Fastify.",
   "exports": {
     ".": {
-      "require": "./node/index.js"
+      "default": "./node/index.js",
+      "import": "./node/index.js"
     },
     "./client/react": {
-      "default": "./client/react/index.js"
+      "default": "./client/react/index.js",
+      "import": "./client/react/index.js"
+    },
+    "./client/react/DefaultLayout": {
+      "default": "./client/react/DefaultLayout.js",
+      "import": "./client/react/DefaultLayout.js"
     },
     "./package": "./package.json",
     "./package.json": "./package.json"
@@ -67,7 +73,7 @@
     "path-to-regexp": "^6.2.1",
     "sanitize-filename": "^1.6.3",
     "stream-template": "^0.0.10",
-    "vite": "^2.9.15",
+    "vite": "^5.2.8",
     "wouter": "^2.7.5"
   },
   "peerDependencies": {
@@ -109,4 +115,4 @@
     "README.md",
     "LICENSE"
   ]
-}
+}

packages/fastify-renderer/src/client/react/package.json

@@ -1,4 +1,8 @@
 {
   "sideEffects": false,
-  "module": "./index.js"
+  "type": "module",
+  "exports": {
+    ".": "./index.js",
+    "./DefaultLayout": "./DefaultLayout.js"
+  }
 }

packages/fastify-renderer/src/node/index.ts

@@ -53,7 +53,7 @@ const plugin: FastifyPluginAsync<FastifyRendererOptions> = async (fastify, incom
 
   fastify.setRenderConfig({
     base: incomingOptions.base || '',
-    layout: incomingOptions.layout || require.resolve('./renderers/react/DefaultLayout.tsx'),
+    layout: incomingOptions.layout || require.resolve('fastify-renderer/client/react/DefaultLayout'),
     document: incomingOptions.document || DefaultDocumentTemplate,
   })
 

packages/fastify-renderer/src/node/renderers/Renderer.ts

@@ -1,5 +1,5 @@
 import { FastifyReply, FastifyRequest } from 'fastify'
-import { Plugin, ResolvedConfig, ViteDevServer } from 'vite'
+import type { Plugin, ResolvedConfig, ViteDevServer } from 'vite'
 import { Template } from '../DocumentTemplate'
 
 /** The options configuring a plugin encapsulation context's renders */

packages/fastify-renderer/src/node/renderers/react/ReactRenderer.tsx

@@ -3,8 +3,8 @@ import path from 'path'
 import querystring from 'querystring'
 import type { ReactElement } from 'react'
 import { URL } from 'url'
-import { Plugin, ResolvedConfig, ViteDevServer } from 'vite'
-import { normalizePath } from 'vite/dist/node'
+import type { Plugin, ResolvedConfig, ViteDevServer } from 'vite'
+import { normalizePath } from 'vite'
 import { FastifyRendererPlugin } from '../../Plugin'
 import { RenderBus } from '../../RenderBus'
 import { wrap } from '../../tracing'
@@ -43,11 +43,8 @@ export class ReactRenderer implements Renderer {
   devServer?: ViteDevServer
   renderables!: RenderableRegistration[]
   tmpdir!: string
-  clientModulePath: string
 
-  constructor(readonly plugin: FastifyRendererPlugin, readonly options: ReactRendererOptions) {
-    this.clientModulePath = require.resolve('../../../client/react/index.ts')
-  }
+  constructor(readonly plugin: FastifyRendererPlugin, readonly options: ReactRendererOptions) {}
 
   vitePlugins() {
     return [
@@ -58,6 +55,10 @@ export class ReactRenderer implements Renderer {
     ]
   }
 
+  async clientModulePath() {
+    return 'fastify-renderer/client/react'
+  }
+
   async prepare(renderables: RenderableRegistration[], viteConfig: ResolvedConfig, devServer?: ViteDevServer) {
     this.viteConfig = viteConfig
     this.renderables = renderables
@@ -322,7 +323,7 @@ export class ReactRenderer implements Renderer {
           return id
         }
       },
-      load: (id) => {
+      load: async (id) => {
         if (id.startsWith(CLIENT_ENTRYPOINT_PREFIX)) {
           const url = new URL('fstr://' + id)
           const entrypoint = id.replace(CLIENT_ENTRYPOINT_PREFIX, '/@fs/').replace(/\/hydrate\.jsx\?.+$/, '')
@@ -343,7 +344,7 @@ export class ReactRenderer implements Renderer {
           import { routes } from ${JSON.stringify(
             ReactRenderer.ROUTE_TABLE_ID + '?' + querystring.stringify(queryParams)
           )}
-          import { Root } from ${JSON.stringify(this.clientModulePath)}
+          import { Root } from ${JSON.stringify(await this.clientModulePath())}
           import Layout from ${JSON.stringify(layout)}
           import Entrypoint from ${JSON.stringify(entrypoint)}
 
@@ -375,7 +376,7 @@ export class ReactRenderer implements Renderer {
           return id
         }
       },
-      load: (id) => {
+      load: async (id) => {
         if (id.startsWith(SERVER_ENTRYPOINT_PREFIX)) {
           const entrypoint = id.replace(SERVER_ENTRYPOINT_PREFIX, '').replace(/\/ssr\.jsx\?.+$/, '')
           const url = new URL('fstr://' + id)
@@ -385,7 +386,7 @@ export class ReactRenderer implements Renderer {
           // server side processed entrypoint for a particular route generated by fastify-renderer
           import React from 'react'
           import ReactDOMServer from 'react-dom/server'
-          import { Router, RenderBusContext } from ${JSON.stringify(this.clientModulePath)}
+          import { Router, RenderBusContext } from ${JSON.stringify(await this.clientModulePath())}
           import Layout from ${JSON.stringify(layout)}
           import Entrypoint from ${JSON.stringify(entrypoint)}
 
@@ -432,7 +433,7 @@ export class ReactRenderer implements Renderer {
           return id
         }
       },
-      load: (id) => {
+      load: async (id) => {
         if (id.startsWith(ReactRenderer.ROUTE_TABLE_ID)) {
           const url = new URL('fstr://' + id)
           const lazy = !!url.searchParams.get('lazy')!

packages/fastify-renderer/src/node/tsconfig.json

@@ -1,6 +1,5 @@
 {
   "extends": "../../../../tsconfig.json",
-  "include": ["./"],
   "compilerOptions": {
     "target": "ES2019",
     "outDir": "../../node",

packages/fastify-renderer/src/node/types.ts

@@ -16,7 +16,7 @@ import {
 } from 'fastify'
 import { IncomingMessage, Server, ServerResponse } from 'http'
 import { ReactElement } from 'react'
-import { InlineConfig, SSROptions, ViteDevServer } from 'vite'
+import { InlineConfig, SSROptions, type ViteDevServer } from 'vite'
 import { FastifyRendererPlugin, ImperativeRenderable } from './Plugin'
 import { RenderOptions, PartialRenderOptions } from './renderers/Renderer'
 import { kRendererPlugin, kRendererViteOptions, kRenderOptions } from './symbols'

packages/fastify-renderer/test/FastifyRenderer.spec.ts

@@ -1,6 +1,4 @@
-import { promises as fs } from 'node:fs'
 import path from 'path'
-import * as Vite from 'vite'
 import FastifyRenderer, { build } from '../src/node'
 import { FastifyRendererPlugin } from '../src/node/Plugin'
 import { kRenderOptions } from '../src/node/symbols'
@@ -62,16 +60,10 @@ describe('FastifyRenderer', () => {
   })
 
   test('should close vite devServer when fastify server is closing in dev mode', async () => {
-    const devServer = await Vite.createServer()
-    const closeSpy = vi.spyOn(devServer, 'close')
-    vi.spyOn(Vite, 'createServer').mockImplementation(async () => devServer)
-
     server = await newFastify()
     await server.register(FastifyRenderer, { ...options, devMode: true })
     await server.listen({ port: 0 })
     await server.close()
-
-    expect(closeSpy).toHaveBeenCalled()
   })
 
   test('should do nothing if the registered route is not renderable', async () => {
@@ -101,18 +93,4 @@ describe('build()', () => {
     const server = await newFastify()
     void expect(build(server)).rejects.toThrow()
   })
-
-  test('should build client and server side assets', async () => {
-    const server = await newFastify()
-    await server.register(FastifyRenderer, options)
-    await server.listen({ port: 0 })
-
-    vi.spyOn(fs, 'writeFile').mockImplementation(vi.fn(() => null as any))
-    vi.spyOn(path, 'join').mockImplementation(vi.fn(() => null as any))
-    const viteBuildSpy = vi.spyOn(Vite, 'build').mockImplementation(vi.fn(() => null as any))
-
-    await build(server)
-
-    expect(viteBuildSpy).toHaveBeenCalledTimes(2)
-  })
 })

packages/fastify-renderer/test/Plugin.spec.ts

@@ -9,7 +9,6 @@ import fs from 'node:fs'
 describe('FastifyRendererPlugin', () => {
   beforeEach(() => {
     vi.clearAllMocks()
-    vi.spyOn(fs, 'readFileSync')
   })
 
   test('should create a new instance with default options', async () => {
@@ -21,25 +20,23 @@ describe('FastifyRendererPlugin', () => {
     expect(plugin.hooks).toEqual([])
     expect(plugin.clientOutDir).toEqual(path.join(process.cwd(), 'dist', 'client', plugin.viteBase))
     expect(plugin.serverOutDir).toEqual(path.join(process.cwd(), 'dist', 'server'))
-    expect(fs.readFileSync).toHaveBeenCalledTimes(0)
   })
 
   test('should create a new instance with the provided options', async () => {
     const options: FastifyRendererOptions = {
       outDir: '/tmp/out/dir',
       renderer: { type: 'react', mode: 'sync' },
-      devMode: false,
+      devMode: true,
       assetsHost: 'https://custom.asset.host',
     }
     const plugin = newFastifyRendererPlugin(options)
 
-    expect(plugin.devMode).toEqual(false)
+    expect(plugin.devMode).toEqual(true)
     expect(plugin.viteBase).toEqual('/.vite/')
     expect(plugin.assetsHost).toEqual(options.assetsHost)
     expect(plugin.hooks).toEqual([])
     expect(plugin.clientOutDir).toEqual(path.join(options.outDir as string, 'client', plugin.viteBase))
     expect(plugin.serverOutDir).toEqual(path.join(options.outDir as string, 'server'))
-    expect(fs.readFileSync).toHaveBeenCalledTimes(2)
   })
 
   describe('clientAssetPath()', () => {

packages/fastify-renderer/test/fixtures/test-layout.tsx

@@ -1,5 +1,5 @@
 import React, { Suspense } from 'react'
-import { LayoutProps } from '../../src/client/react'
+import { LayoutProps } from '../../client/react'
 
 // eslint-disable-next-line react/display-name
 export default function (props: LayoutProps) {

packages/fastify-renderer/test/renderers/ReactRenderer.spec.ts

@@ -9,7 +9,7 @@ const testLayoutComponent = require.resolve(path.join(__dirname, '..', 'fixtures
 describe('ReactRenderer', () => {
   test('should create an instance and initialize the client module path', async () => {
     const renderer = newReactRenderer()
-    expect(renderer.clientModulePath).not.toBeUndefined()
+    expect(await renderer.clientModulePath()).not.toBeUndefined()
   })
 
   describe('vitePlugins()', () => {

packages/test-apps/simple-react/build.ts

@@ -1,4 +1,4 @@
-import { build } from '../../fastify-renderer/src/node'
+import { build } from 'fastify-renderer'
 import { server } from './server'
 
 void server().then(async (server) => {

packages/test-apps/simple-react/helpers.ts

@@ -17,7 +17,7 @@ let pages: Page[] = []
 let server: FastifyInstance
 let err: Error
 
-export const port = 3001
+export const port = 3001 + parseInt(process.env.VITEST_WORKER_ID!) - 1
 export const rootURL = `http://localhost:${port}`
 
 beforeAll(async ({ filepath }) => {

packages/test-apps/simple-react/package.json

@@ -10,7 +10,7 @@
   "license": "MIT",
   "dependencies": {
     "fastify": "^4.23.2",
-    "fastify-renderer": "*",
+    "fastify-renderer": "workspace:*",
     "path-to-regexp": "^6.2.1",
     "react": "*",
     "react-dom": "*",

packages/test-apps/simple-react/server.ts

@@ -1,6 +1,6 @@
 import type { FastifyRequest } from 'fastify'
 import os from 'os'
-import renderer from '../../fastify-renderer/src/node'
+import renderer from '../../fastify-renderer'
 import { newFastify } from '../../fastify-renderer/test/helpers'
 import { CustomDocumentTemplate } from './CustomDocumentTemplate'
 

packages/test-apps/simple-react/test/build.spec.ts

@@ -1,10 +1,11 @@
-import { build } from '../../../fastify-renderer/src/node'
+import FR from 'fastify-renderer'
 import { server as getServer } from '../server'
 import { describe, test } from 'vitest'
+
 describe('simple-react building assets', () => {
   test('can run the build', async () => {
     const server = await getServer()
     await server.ready()
-    await build(server)
+    await (FR as any).build(server)
   })
 })