Check context after acquiring key #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change looks good to me, do we want to move this to the 1.19 branch instead? |
Yeah, you're right. I'll make the 1.19 branch today and move it 👍 |
scott-rc
force-pushed
the
sc/check-ctx-after-acquiring-key
branch
from
83df4f6 to
41f5ca3
Compare
|
Rebased on 1.19 branch and bumped min deadline left from 1 second -> 3 seconds |
angelini
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks our
ctxafter acquiring a key fromreadyPodQueue. If the context is cancelled or about to be cancelled we add the key back and give up.I arbitrarily chose 1 second as our "to close to being cancelled" limit but I'm open to change that.