Updated AutoButton type to accept non-string children

gadget-inc · Nov 6, 2024 · e77236b · e77236b
1 parent 798fe22
commit e77236b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/packages/react/.changeset/famous-garlics-enjoy.md b/packages/react/.changeset/famous-garlics-enjoy.md
@@ -0,0 +1,5 @@
+---
+"@gadgetinc/react": patch
+---
+
+Updated AutoButton type to accept non-string children
diff --git a/packages/react/src/auto/polaris/PolarisAutoButton.tsx b/packages/react/src/auto/polaris/PolarisAutoButton.tsx
@@ -16,7 +16,8 @@ export const PolarisAutoButton = <
   SchemaT,
   ActionFunc extends ActionFunction<GivenOptions, any, any, SchemaT, any> | GlobalActionFunction<any>
 >(
-  props: AutoButtonProps<GivenOptions, SchemaT, ActionFunc> & ComponentProps<typeof Button>
+  props: AutoButtonProps<GivenOptions, SchemaT, ActionFunc> &
+    Omit<ComponentProps<typeof Button>, "children"> & { children?: React.ReactNode }
 ) => {
   const { fetching, running, isDestructive, run, label, buttonProps } = useAutoButtonController({
     onSuccess: (_result) => {
@@ -38,6 +39,7 @@ export const PolarisAutoButton = <
 
   return (
     <Button loading={running} disabled={fetching} tone={isDestructive ? "critical" : undefined} onClick={run} {...buttonProps}>
+      {/* @ts-expect-error  // Polaris Button children types demands strings, but ReactComponents work*/}
       {props?.children ?? label}
     </Button>
   );