Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api-client-core should propagate error for live queries #698

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

garymardell
Copy link
Collaborator

See #697 for details.

This PR just merges the api-client-core portion of the PR as it seems like you can't bump api-client-core and it's usage in a single PR. This is because the vite test does an pnpm install with the new version number, however that can't be found because it hasn't been released yet (until the PR is merged).

PR Checklist

  • Important or complicated code is tested
  • Any user facing changes are documented in the Gadget-side changelog
  • Any immediate changes are slated for release in Gadget via a generated package dependency bump
  • Versions within this monorepo are matching and there's a valid upgrade path

@garymardell garymardell merged commit 4c83d95 into main Nov 22, 2024
9 checks passed
@garymardell garymardell deleted the live-query-core branch November 22, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants