Update js-clients to process action responses #703
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The response from an upsert action was not being properly handled by
useAction
and therefore the data was not being returned to the user. This was because theaction.hasReturnType
looks like:in the useAction processResult it would just check if
action.hasReturnType
is truthy and if so usemutationData.result
. However in this case the value is truthy but an object not a boolean value.We already have the utility inside the
api-client-core
to process the action results (which is used both by the core action runner and background actions) which handles this case correctly so this updates the code to use that instead.PR Checklist