Feature/shadcn skeleton #732
Conversation
| <button id="setFindById1" onClick={() => setFindBy("1")} /> | ||
| <button id="setFindById2" onClick={() => setFindBy("2")} /> | ||
| <button style={{ width: 1, height: 1 }} id="setFindById1" onClick={() => setFindBy("1")} /> | ||
| <button style={{ width: 1, height: 1 }} id="setFindById2" onClick={() => setFindBy("2")} /> |
There was a problem hiding this comment.
Shouldn't buttons have a default style that makes them have dimensions and be findable? this works but i wouldn't have thought it was necessary. Could the issue be that something is on top of the buttons?
There was a problem hiding this comment.
Because there is no label or text inbetween the button, it won't have anything.
If we did hello then the button will take up the space of the hello
|
|
||
| interface AutoSuiteConfig { | ||
| name: string; | ||
| adapter: AutoAdapter; | ||
| wrapper: ComponentType<{ children: ReactNode }>; | ||
| } | ||
|
|
||
| const ONLY_RUN_SUITES = { | ||
| [SUITE_NAMES.SHADCN]: ["AutoButton"], |
There was a problem hiding this comment.
I am down for this, but it does mean all the autoinputs stuff that is landing in this PR is untested for now, right?
There was a problem hiding this comment.
Yes it is untested for now. I am bringing <autoform /> in soon, which will include some cypress tests for the autoInput and will take a look at what we have for jests if we do and convert it. Just trying to get some stability
The Shadcn Skeleton which gives us the ability to integrate Shadcn and Gagdet
PR Checklist
Occasionally that error was coming up so added
width&heightAlso added a click & Type command as was experiencing issues with Shadcn input components in cypress
cypress-io/cypress#5830
cypress-io/cypress#5827