add TypeScript typings #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any progress on merging this? Looks good for me. cc @gaearon |
|
Up. |
|
> require('react-side-effect')
[Function: withSideEffect]
> require('react-side-effect').default
undefined |
|
now :)? |
|
LGTM |
|
rewind() is missing. |
JakeSidSmith
suggested changes
Aug 31, 2018
There was a problem hiding this comment.
@gaearon could we get this PR merged after these changes? Its' been 2 years...
| interface IDocumentTitleProps { | ||
| title: string; | ||
| } | ||
| declare class DocumentTitle extends Component<IDocumentTitleProps, void> {} |
There was a problem hiding this comment.
void is not valid in newer React types. You should use {} for back and forward compatibility.
| @@ -0,0 +1,6 @@ | |||
| import {Component} from 'react'; | |||
| interface IDocumentTitleProps { | |||
There was a problem hiding this comment.
I would rename the interface DocumentTitleProps. It is not recommended to prefix interfaces with I (although its somewhat still up for debate).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds TypeScript typings