Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purely return props.children, allowing multiple children #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Purely return props.children, allowing multiple children #53

wants to merge 1 commit into from

Conversation

serprex
Copy link

@serprex serprex commented Feb 14, 2018

Closes #48

@flaviouk
Copy link

@gaearon Merge this anytime soon?

@serprex
Copy link
Author

serprex commented May 15, 2019

If there's controversy over how this changes more than necessary, all that needs to really be done for #48 is removing the call to React.Children.only

@silverwind
Copy link

Bump! Having to wrap <DocumentTitle>'s children in <React.Fragment> is so unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use of React.Children.only()
3 participants
@serprex @flaviouk @silverwind