-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot set property displayName on class which has only a getter #845
Closed
Labels
Comments
temporary solution
I still think that createClassProxy should support static get displayName |
Ok, I'll just use safeDefineProperty as we use for the rest of props. |
theKashey
added a commit
that referenced
this issue
Feb 13, 2018
Should be fixed in beta.23. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
This part of code is unable to set displayName because class has only getter's
react-hot-loader/packages/react-stand-in/src/createClassProxy.js
Expected behavior
react-hot-loader should support classes with static getter's like
Actual behavior
react-hot-loader/packages/react-stand-in/src/createClassProxy.js
Environment
React Hot Loader version: 4.0.0-beta.21
Node version: v8.9.4
NPM version: 5.1.0
Ubuntu 14.04
Google Chrome: 64
The text was updated successfully, but these errors were encountered: