-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle lazy indeterminate static properties #1014
Conversation
No tests 😭 |
I'm back with more "fun" on weird React features used in Relay. Relay now does this: facebook/relay@0573d77 So... we need to also lazily proxy over |
Sorry, tests forthcoming! Wanted to get the PR up to point people at what was happening. |
Codecov Report
@@ Coverage Diff @@
## master #1014 +/- ##
==========================================
+ Coverage 86.52% 86.54% +0.01%
==========================================
Files 31 31
Lines 824 825 +1
Branches 193 193
==========================================
+ Hits 713 714 +1
Misses 92 92
Partials 19 19
Continue to review full report at Codecov.
|
Updated the test case to cover this. |
👍 |
@taion - ok to merge? Is this the only change you need? |
Yup, this is the only change. I’m not 100% sure that my use of |
It sounds to be correct. Anyway - I should not break anything. |
v 4.3.1 |
No description provided.