-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Webpack injector #1101
Feat: Webpack injector #1101
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1101 +/- ##
==========================================
- Coverage 86.56% 85.44% -1.12%
==========================================
Files 32 33 +1
Lines 945 1010 +65
Branches 231 254 +23
==========================================
+ Hits 818 863 +45
- Misses 106 117 +11
- Partials 21 30 +9
Continue to review full report at Codecov.
|
It is AWESOME, I like the idea to monkey patch React 👌 |
Dose both babel plugin and webpack loader are required for it to work? |
|
Lets discuss all the problems in #1088 |
This PR is aimed to implement react RFC reactjs/rfcs#74
As long as there is no activity on the original RFC, and there is no way to introduce that comparison to the already published version I am going to....
Use webpack loader to inject necessary changes into the React-Dom
🙌 🙌 🙌 🙌 🙌 🙌
And it's actually working, letting us support any React Feature from the past or the future.
React.lazy
(build-in)It would
import
lazy automaticaly, providing auto-reloading of the changed chunks.React.memo
(requires patch) Now it could deep-force-update even memo-ed components, working with fiber directly. (landing additional prop on memoizedProps to bypass shallow equal)
React.forwardRef
(requires patch) Now it could update components, working with fiber directly
Hooks
(requires patch) Could work with hooks with
pureSFC
enabled, orignoreSFC
activated