Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding clarification to RHL3 docs + JSX highlight in code blocks #258

Merged
merged 2 commits into from
Apr 26, 2016

Conversation

tsaiDavid
Copy link
Contributor

@gadicc @hedgerh @gaearon - Went ahead and added the changes I mentioned along with some other little touches.

  • Clarification and showing the JSX syntax with the AppContainer component wrapping RootContainer - hopefully this is more beginner friendly and less confusing since v3 will require a bit more config.
  • Switched from js to jsx for the code blocks, if I'm not mistaken it's GitHub markdown friendly 👍
  • Provided super basic start for us to show usage within webpack loader (just to get the ball rolling)

@tsaiDavid
Copy link
Contributor Author

Just want to point out I was also able to update the shell command example, prefixed it with the $ symbol that we typically see, indicating that it is a command to be used from one's terminal.

An example was also not in consistent ES6 as in our other examples, so I updated it.

@tsaiDavid
Copy link
Contributor Author

@gadicc #257 #243 - apologies for all the comments, just want to make sure I'm referencing the issue correctly, please let me know if there's anything else I can do.

@gadicc
Copy link
Collaborator

gadicc commented Apr 26, 2016

this is awesome, @tsaiDavid, thanks! all very welcome improvements. just one issue which I'll comment on in the diff and then I'm happy to merge. yeah, for future it's enough to just put a #257 in there somewhere and we'll get a notification (I think :)).

@@ -20,7 +20,8 @@ First we had React Hot Loader, which was superseded by React Transform. Each ti
* Works with or without Babel
* Everything you need in a single repo

For more information on the evolution of approaches taken, see [](https://medium.com/@dan_abramov/hot-reloading-in-react-1140438583bf)https://medium.com/@dan_abramov/hot-reloading-in-react-1140438583bf.
For more information on the evolution of approaches taken
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just this snuck through :)

@gadicc gadicc merged commit 1296c3f into gaearon:next-docs Apr 26, 2016
@gadicc
Copy link
Collaborator

gadicc commented Apr 26, 2016

@tsaiDavid I'm going to fix that line on my side, these were actually intended for the gh-pages (sorry that's my bad) so need to move these there and then I'll ping you again. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants