Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails on IE11 Win10 (no Array.prototype.find) #52

Closed
gnarf opened this issue Mar 9, 2016 · 2 comments · Fixed by #53
Closed

Fails on IE11 Win10 (no Array.prototype.find) #52

gnarf opened this issue Mar 9, 2016 · 2 comments · Fixed by #53

Comments

@gnarf
Copy link

gnarf commented Mar 9, 2016

react-proxy/src/createClassProxy.js

Line 35 in 2d79a5b

const pair = allProxies.find(([key]) => key === Component);

This line is calling [].find which doesn't exist in IE11.

screenshot 2016-03-09 15 37 05

screenshot 2016-03-09 15 37 21
@Restuta
Copy link
Contributor

Restuta commented Mar 10, 2016

same issue

Restuta added a commit to Restuta/react-proxy that referenced this issue Mar 10, 2016
@Restuta
replacing prototype.find on lodash find, since it breaks in IE11 !
e6ce7fa 
closes gaearon#52
@Restuta Restuta mentioned this issue Mar 10, 2016
Merged
gaearon pushed a commit that referenced this issue Mar 10, 2016
@Restuta @gaearon
replacing prototype.find on lodash find, since it breaks in IE11 !
217b4ad 
closes #52
@gaearon
Copy link
Owner

gaearon commented Mar 10, 2016

Thanks! Fix is out in 1.1.8.

@tinfoil-globe tinfoil-globe mentioned this issue Mar 18, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replacing prototype.find on lodash find, since it breaks in IE11 ! Restuta/react-proxy
3 participants
@Restuta @gnarf @gaearon