gaearon · jamiebuilds · Oct 31, 2018 · Nov 1, 2018 · Nov 1, 2018 · Nov 2, 2018
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -40,3 +40,9 @@ jobs:
  key: v1-node-{{ arch }}-{{ .Branch }}-{{ checksum "yarn.lock" }}
  paths:
  - node_modules
+
+ - store_artifacts:
+ path: ./node_modules.tgz
+
+ - store_artifacts:
+ path: ./scripts/error-codes/codes.json
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -1,5 +1,10 @@
 'use strict';
 
+const {
+ es5Paths,
+ esNextPaths,
+} = require('./scripts/shared/pathsByLanguageVersion');
+
 const OFF = 0;
 const ERROR = 2;
 
@@ -16,6 +21,15 @@ module.exports = {
  'react-internal',
  ],
 
+ parser: 'espree',
+ parserOptions: {
+ ecmaVersion: 2017,
+ sourceType: 'script',
+ ecmaFeatures: {
+ experimentalObjectRestSpread: true,
+ },
+ },
+
  // We're stricter than the default config, mostly. We'll override a few rules
  // and then enable some React specific ones.
  rules: {
@@ -44,6 +58,13 @@ module.exports = {
  'space-before-function-paren': OFF,
  'valid-typeof': [ERROR, {requireStringLiterals: true}],
 
+ // We apply these settings to files that should run on Node.
+ // They can't use JSX or ES6 modules, and must be in strict mode.
+ // They can, however, use other ES6 features.
+ // (Note these rules are overridden later for source files.)
+ 'no-var': ERROR,
+ strict: ERROR,
+
  // React & JSX
  // Our transforms set this automatically
  'react/jsx-boolean-value': [ERROR, 'always'],
@@ -71,6 +92,33 @@ module.exports = {
  },
 
  overrides: [
+ {
+ // We apply these settings to files that we ship through npm.
+ // They must be ES5.
+ files: es5Paths,
+ parser: 'espree',
+ parserOptions: {
+ ecmaVersion: 5,
+ sourceType: 'script',
+ },
+ rules: {
+ 'no-var': OFF,
+ strict: ERROR,
+ },
+ },
+ {
+ // We apply these settings to the source files that get compiled.
+ // They can use all features including JSX (but shouldn't use `var`).
+ files: esNextPaths,
+ parser: 'babel-eslint',
+ parserOptions: {
+ sourceType: 'module',
+ },
+ rules: {
+ 'no-var': ERROR,
+ strict: OFF,
+ },
+ },
  {
  files: ['**/__tests__/*.js'],
  rules: {

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,9 +4,56 @@
  Changes that have landed in master but are not yet released.
  Click to see more.
  </summary>
-
 </details>
 
+## 16.7.0 (December 19, 2018)
+
+### React DOM
+
+* Fix performance of `React.lazy` for large numbers of lazily-loaded components. ([@acdlite](http://github.com/acdlite) in [#14429](https://github.com/facebook/react/pull/14429))
+* Clear fields on unmount to avoid memory leaks. ([@trueadm](http://github.com/trueadm) in [#14276](https://github.com/facebook/react/pull/14276))
+* Fix bug with SSR and context when mixing `react-dom/server@16.6` and `react@<16.6`. ([@gaearon](http://github.com/gaearon) in [#14291](https://github.com/facebook/react/pull/14291))
+* Fix a performance regression in profiling mode. ([@bvaughn](http://github.com/bvaughn) in [#14383](https://github.com/facebook/react/pull/14383))
+
+### Scheduler (Experimental)
+
+* Post to MessageChannel instead of window. ([@acdlite](http://github.com/acdlite) in [#14234](https://github.com/facebook/react/pull/14234))
+* Reduce serialization overhead. ([@developit](http://github.com/developit) in [#14249](https://github.com/facebook/react/pull/14249))
+* Fix fallback to `setTimeout` in testing environments. ([@bvaughn](http://github.com/bvaughn) in [#14358](https://github.com/facebook/react/pull/14358))
+* Add methods for debugging. ([@mrkev](http://github.com/mrkev) in [#14053](https://github.com/facebook/react/pull/14053))
+
+
+## 16.6.3 (November 12, 2018)
+
+### React DOM
+
+* Fix bugs in `Suspense` and `lazy`. ([@acdlite](https://github.com/acdlite) in [#14133](https://github.com/facebook/react/pull/14133), [#14157](https://github.com/facebook/react/pull/14157), and [#14164](https://github.com/facebook/react/pull/14164))
+* Fix highlighting of `React.memo` updates in React DevTools. ([@bvaughn](https://github.com/bvaughn) in [#14141](https://github.com/facebook/react/pull/14141))
+* Fix interaction of Suspense with the React Profiler. ([@bvaughn](https://github.com/bvaughn) in [#14065](https://github.com/facebook/react/pull/14065))
+* Fix a false positive warning when using Suspense. ([@acdlite](https://github.com/acdlite) in [#14158](https://github.com/facebook/react/pull/14158))
+
+### React DOM Server
+
+* Fix incorrect sharing of context state between `renderToNodeStream()` calls. ([@sebmarkbage](https://github.com/sebmarkbage) in [#14182](https://github.com/facebook/react/pull/14182))
+* Add a warning about incorrect usage of the context API. ([@trueadm](https://github.com/trueadm) in [#14033](https://github.com/facebook/react/pull/14033))
+
+## 16.6.2 (November 12, 2018)
+
+This release was published in a broken state and should be skipped.
+
+## 16.6.1 (November 6, 2018)
+
+### React DOM
+
+* Fallback should not remount every time a promise resolves. ([@acdlite](https://github.com/acdlite) in [#14083](https://github.com/facebook/react/pull/14083))
+* Fix bug where Suspense keeps showing fallback even after everything finishes loading. ([@acdlite](https://github.com/acdlite) in [#14083](https://github.com/facebook/react/pull/14083))
+* Fix unresolved default props in lifecycle methods of a lazy component. ([@gaearon](https://github.com/gaearon) in [#14112](https://github.com/facebook/react/pull/14112))
+* Fix bug when recovering from an error thrown during complete phase. ([@gaearon](https://github.com/gaearon) in [#14104](https://github.com/facebook/react/pull/14104))
+
+### Scheduler (Experimental)
+
+* Switch from deadline object to `shouldYield` API. ([@acdlite](https://github.com/acdlite) in [#14025](https://github.com/facebook/react/pull/14025))
+
 
 ## 16.6.0 (October 23, 2018)
 
@@ -95,7 +142,7 @@
 * Fix incorrect data in `compositionend` event when typing Korean on IE11 ([@crux153](https://github.com/crux153) in [#12563](https://github.com/facebook/react/issues/12563))
 * Fix a crash when using dynamic `children` in the `<option>` tag ([@Slowyn](https://github.com/Slowyn) in [#13261](https://github.com/facebook/react/issues/13261), [@gaearon](https://github.com/gaearon) in [#13465](https://github.com/facebook/react/pull/13465))
 * Fix the `checked` attribute not getting initially set on the `input` ([@dilidili](https://github.com/dilidili) in [#13114](https://github.com/facebook/react/issues/13114))
-* Fix hydration of `dangerouslySetInnerHTML` when `__html` is not a string ([@gaearon](https://github.com/gaearon) in [#13353](https://github.com/facebook/react/issues/13353)) 
+* Fix hydration of `dangerouslySetInnerHTML` when `__html` is not a string ([@gaearon](https://github.com/gaearon) in [#13353](https://github.com/facebook/react/issues/13353))
 * Fix a warning about missing controlled `onChange` to fire on falsy values too ([@nicolevy](https://github.com/nicolevy) in [#12628](https://github.com/facebook/react/issues/12628))
 * Fix `submit` and `reset` buttons getting an empty label ([@ellsclytn](https://github.com/ellsclytn) in [#12780](https://github.com/facebook/react/issues/12780))
 * Fix the `onSelect` event not being triggered after drag and drop ([@gaearon](https://github.com/gaearon) in [#13422](https://github.com/facebook/react/issues/13422))
@@ -286,7 +333,7 @@
 * Deduplicate warning messages about invalid callback. ([@yenshih](https://github.com/yenshih) in [#11833](https://github.com/facebook/react/pull/11833))
 * Deprecate `ReactDOM.unstable_createPortal()` in favor of `ReactDOM.createPortal()`. ([@prometheansacrifice](https://github.com/prometheansacrifice) in [#11747](https://github.com/facebook/react/pull/11747))
 * Don't emit User Timing entries for context types. ([@abhaynikam](https://github.com/abhaynikam) in [#12250](https://github.com/facebook/react/pull/12250))
-* Improve the error message when context consumer child isn't a function. ([@raunofreiberg](https://github.com/raunofreiberg) in [#12267](https://github.com/facebook/react/pull/12267)) 
+* Improve the error message when context consumer child isn't a function. ([@raunofreiberg](https://github.com/raunofreiberg) in [#12267](https://github.com/facebook/react/pull/12267))
 * Improve the error message when adding a ref to a functional component. ([@skiritsis](https://github.com/skiritsis) in [#11782](https://github.com/facebook/react/pull/11782))
 
 ### React DOM Server

diff --git a/dangerfile.js b/dangerfile.js
@@ -17,7 +17,7 @@
 //
 // You'll need a GitHub token, you can re-use this one:
 //
-// e622517d9f1136ea8900 07c6373666312cdfaa69
+// 0a7d5c3cad9a6dbec2d9 9a5222cf49062a4c1ef7
 //
 // (Just remove the space)
 //
@@ -29,9 +29,16 @@ const {markdown, danger} = require('danger');
 const fetch = require('node-fetch');
 
 const {generateResultsArray} = require('./scripts/rollup/stats');
-const {readFileSync} = require('fs');
+const {existsSync, readFileSync} = require('fs');
 const {exec} = require('child_process');
 
+if (!existsSync('./scripts/rollup/results.json')) {
+ // This indicates the build failed previously.
+ // In that case, there's nothing for the Dangerfile to do.
+ // Exit early to avoid leaving a redundant (and potentially confusing) PR comment.
+ process.exit(0);
+}
+
 const currentBuildResults = JSON.parse(
  readFileSync('./scripts/rollup/results.json')
 );

diff --git a/fixtures/art/VectorWidget.js b/fixtures/art/VectorWidget.js
@@ -32,7 +32,7 @@ class VectorWidget extends React.Component {
  /**
  * When the component is mounted into the document - this is similar to a
  * constructor, but invoked when the instance is actually mounted into the
- * document. Here's, we'll just set up an animation loop that invokes our
+ * document. Here, we'll just set up an animation loop that invokes our
  * method. Binding of `this.onTick` is not needed because all React methods
  * are automatically bound before being mounted.
  */

diff --git a/fixtures/attribute-behavior/package.json b/fixtures/attribute-behavior/package.json
@@ -12,7 +12,7 @@
  },
  "scripts": {
  "prestart":
- "cp ../../build/dist/react.development.js public/ && cp ../../build/dist/react-dom.development.js public/ && cp ../../build/dist/react-dom-server.browser.development.js public/",
+ "cp ../../build/node_modules/react/umd/react.development.js public/ && cp ../../build/node_modules/react-dom/umd/react-dom.development.js public/ && cp ../../build/node_modules/react-dom/umd/react-dom-server.browser.development.js public/",
  "start": "react-scripts start",
  "build": "react-scripts build",
  "test": "react-scripts test --env=jsdom",

diff --git a/fixtures/attribute-behavior/src/App.js b/fixtures/attribute-behavior/src/App.js
@@ -860,7 +860,7 @@ class App extends React.Component {
  });
  break;
  default:
- throw new Error('Switch statement should be exhuastive');
+ throw new Error('Switch statement should be exhaustive');
  }
 
  // Sort
@@ -887,7 +887,7 @@ class App extends React.Component {
  });
  }
  default:
- throw new Error('Switch statement should be exhuastive');
+ throw new Error('Switch statement should be exhaustive');
  }
  }
 

diff --git a/fixtures/dom/.gitignore b/fixtures/dom/.gitignore
@@ -9,8 +9,11 @@ coverage
 # production
 build
 public/react.development.js
+public/react.production.min.js
 public/react-dom.development.js
+public/react-dom.production.min.js
 public/react-dom-server.browser.development.js
+public/react-dom-server.browser.production.min.js
 
 # misc
 .DS_Store

diff --git a/fixtures/dom/package.json b/fixtures/dom/package.json
@@ -18,7 +18,7 @@
  },
  "scripts": {
  "start": "react-scripts start",
- "prestart": "cp ../../build/dist/react.development.js ../../build/dist/react-dom.development.js ../../build/dist/react-dom-server.browser.development.js public/",
+ "prestart": "cp ../../build/node_modules/react/umd/react.development.js ../../build/node_modules/react-dom/umd/react-dom.development.js ../../build/node_modules/react/umd/react.production.min.js ../../build/node_modules/react-dom/umd/react-dom.production.min.js ../../build/node_modules/react-dom/umd/react-dom-server.browser.development.js ../../build/node_modules/react-dom/umd/react-dom-server.browser.production.min.js public/",
  "build": "react-scripts build && cp build/index.html build/200.html",
  "test": "react-scripts test --env=jsdom",
  "eject": "react-scripts eject"

diff --git a/fixtures/dom/src/components/Header.js b/fixtures/dom/src/components/Header.js
@@ -7,8 +7,9 @@ class Header extends React.Component {
  super(props, context);
  const query = parse(window.location.search);
  const version = query.version || 'local';
+ const production = query.production || false;
  const versions = [version];
- this.state = {version, versions};
+ this.state = {version, versions, production};
  }
  componentWillMount() {
  getVersionTags().then(tags => {
@@ -25,6 +26,14 @@ class Header extends React.Component {
  }
  window.location.search = stringify(query);
  }
+ handleProductionChange(event) {
+ const query = parse(window.location.search);
+ query.production = event.target.checked;
+ if (!query.production) {
+ delete query.production;
+ }
+ window.location.search = stringify(query);
+ }
  handleFixtureChange(event) {
  window.location.pathname = event.target.value;
  }
@@ -43,6 +52,16 @@ class Header extends React.Component {
  </span>
 
  <div className="header-controls">
+ <input
+ id="react_production"
+ className="header__checkbox"
+ type="checkbox"
+ checked={this.state.production}
+ onChange={this.handleProductionChange}
+ />
+ <label htmlFor="react_production" className="header__label">
+ Production
+ </label>
  <label htmlFor="example">
  <span className="sr-only">Select an example</span>
  <select

diff --git a/fixtures/dom/src/react-loader.js b/fixtures/dom/src/react-loader.js
@@ -37,12 +37,15 @@ function loadScript(src) {
 }
 
 export function reactPaths() {
- let reactPath = 'react.development.js';
- let reactDOMPath = 'react-dom.development.js';
- let reactDOMServerPath = 'react-dom-server.browser.development.js';
-
  let query = parseQuery(window.location.search);
  let version = query.version || 'local';
+ let isProduction = query.production === 'true';
+
+ let environment = isProduction ? 'production.min' : 'development';
+
+ let reactPath = 'react.' + environment + '.js';
+ let reactDOMPath = 'react-dom.' + environment + '.js';
+ let reactDOMServerPath = 'react-dom-server.browser.' + environment + '.js';
 
  if (version !== 'local') {
  const {major, minor, prerelease} = semver(version);
@@ -51,21 +54,34 @@ export function reactPaths() {
  // Load the old module location for anything less than 16 RC
  if (major >= 16 && !(minor === 0 && preReleaseStage === 'alpha')) {
  reactPath =
- 'https://unpkg.com/react@' + version + '/umd/react.development.js';
+ 'https://unpkg.com/react@' +
+ version +
+ '/umd/react.' +
+ environment +
+ '.js';
  reactDOMPath =
  'https://unpkg.com/react-dom@' +
  version +
- '/umd/react-dom.development.js';
+ '/umd/react-dom.' +
+ environment +
+ '.js';
  reactDOMServerPath =
  'https://unpkg.com/react-dom@' +
  version +
- '/umd/react-dom-server.browser.development';
+ '/umd/react-dom-server.browser.' +
+ environment +
+ '.js';
  } else {
- reactPath = 'https://unpkg.com/react@' + version + '/dist/react.js';
+ let suffix = isProduction ? '.min.js' : '.js';
+
+ reactPath = 'https://unpkg.com/react@' + version + '/dist/react' + suffix;
  reactDOMPath =
- 'https://unpkg.com/react-dom@' + version + '/dist/react-dom.js';
+ 'https://unpkg.com/react-dom@' + version + '/dist/react-dom' + suffix;
  reactDOMServerPath =
- 'https://unpkg.com/react-dom@' + version + '/dist/react-dom-server.js';
+ 'https://unpkg.com/react-dom@' +
+ version +
+ '/dist/react-dom-server' +
+ suffix;
  }
  }
 

diff --git a/fixtures/dom/src/style.css b/fixtures/dom/src/style.css
@@ -126,6 +126,15 @@ textarea {
  width: 100%;
 }
 
+.header__checkbox {
+ vertical-align: middle;
+}
+
+.header__label {
+ font-size: 12px;
+ color: #ccc;
+}
+
 .sr-only {
  clip: rect(0, 0, 0, 0);
  height: 0;

diff --git a/fixtures/eslint/.eslintrc.json b/fixtures/eslint/.eslintrc.json
@@ -0,0 +1,15 @@
+{
+ "root": true,
+ "parserOptions": {
+ "ecmaVersion": 6,
+ "sourceType": "module",
+ "ecmaFeatures": {
+ "jsx": true
+ }
+ },
+ "plugins": ["react-hooks"],
+ "rules": {
+ "react-hooks/rules-of-hooks": 2,
+ "react-hooks/reactive-deps": 2
+ }
+}
diff --git a/fixtures/eslint/README.md b/fixtures/eslint/README.md
@@ -0,0 +1,7 @@
+# ESLint Playground Fixture
+
+This is an internal playground for quick iteration on our lint rules inside an IDE like VSCode.
+
+See instructions in `./index.js` in this directory.
+
+![Demo](https://duaw26jehqd4r.cloudfront.net/items/2Z390a31003O0l0o0e3O/Screen%20Recording%202019-01-16%20at%2010.29%20PM.gif?v=d6856125)