Make type casting configurable #12
Open
+105
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow! Very good job. This was one of the things I had in mind. |
|
Thanks.. 😉 |
|
If all is in order, may I encourage you to proceed with the merge? I've been pointing my package.json to my fork for a while, but I'd rather point to a published module.. 😄 |
|
I'm doing the v2.0.0, I'll include this feature. |
|
Hi @gagle, any plans to merge this PR? |
|
+1, this would really be useful (e.g when parsing a properties file that contains version numbers...) |
|
Any updates on this merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can see how the automatic casting of property values to JavaScript types might come in useful, but sometimes you really just want the literal value.
For my use case: I am reading a properties file containing mappings between file names and their SHA-1 hashes, truncated to 8 characters. Some of those hashes might look like numbers in exponential notation, say '90e02100', in which case having them cast to a Number is definitely not a good thing.
The same could be argued for numbers in octal or hex notation, I guess.
So, as per subject, I made this configurable, added the relevant tests and updated the Readme.