Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly merging of multiple assays when accessing #246

Closed
c-mertes opened this issue Aug 12, 2021 · 0 comments
Closed

Correctly merging of multiple assays when accessing #246

c-mertes opened this issue Aug 12, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@c-mertes
Copy link
Contributor

It is not completely clear what the function should return. It allows for multiple assays but it is not specified how the data should be merged. The groupedIDs.update(xxx) will just replace any existing keys with the new values. To me this looks like we should rather merge uniquely all IDs into the given groups, which is not happening, as only the top level (keys) are merged and if already present overwritten.

https://github.com/gagneurlab/drop/blob/master/drop/config/SampleAnnotation.py#L275-L291

A use case would be: I would like to have all IDs for RNA samples (RNA) and externally provided samples (GENE_COUNTS).

The question now is how do we merge the lists within one entry? Concatenating or making it unique. Is the order important or not. Would it be ok to have the same ID within different assays?

What do you think @vyepez88 @mumichae

@c-mertes c-mertes added the bug Something isn't working label Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants