Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sorting used in package import #122

Merged
merged 1 commit into from
Oct 8, 2018

Conversation

mavimo
Copy link
Contributor

@mavimo mavimo commented Oct 7, 2018

Use the sorting suggested for go projects for package import, fixing
files that are not compliant.

Use the sorting suggested for go projects for package import, fixing
files that are not compliant.
@mavimo mavimo changed the title fix order used in package import Fix sorting used in package import Oct 7, 2018
@codecov-io
Copy link

Codecov Report

Merging #122 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   64.61%   64.61%           
=======================================
  Files          24       24           
  Lines        2063     2063           
=======================================
  Hits         1333     1333           
  Misses        580      580           
  Partials      150      150
Impacted Files Coverage Δ
handlers/handler.go 85.13% <ø> (ø) ⬆️
handlers/hook.go 62.5% <ø> (ø) ⬆️
handlers/user.go 27.27% <ø> (ø) ⬆️
workers/pipeline/git.go 69.33% <ø> (ø) ⬆️
handlers/vault.go 63.63% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 413494f...ebeebf9. Read the comment docs.

@Skarlso Skarlso merged commit f3c56cf into gaia-pipeline:master Oct 8, 2018
@mavimo mavimo deleted the fix-import-order branch October 8, 2018 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants